update cerebro/prevent errors/add ldap auth #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psmiraglia
reviewed
Jun 14, 2019
psmiraglia
left a comment
psmiraglia
left a comment
There was a problem hiding this comment.
Why should we be able to skip the hash verification? Which is the use case? If you're considering the use of an unofficial binary, I think you should implement also the customization (via pillar) of source parameter.
psmiraglia
reviewed
Jun 14, 2019
psmiraglia
left a comment
psmiraglia
left a comment
There was a problem hiding this comment.
The "documentation" in defaults.yaml shoud be aligned to the new settings.
cerebro-formula/cerebro/defaults.yaml
Lines 13 to 18 in 274646a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.